Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: avoid ProjectoinExec's goroutine leak (#14127) #14226

Merged
merged 2 commits into from
Dec 26, 2019
Merged

executor: avoid ProjectoinExec's goroutine leak (#14127) #14226

merged 2 commits into from
Dec 26, 2019

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Dec 25, 2019

What problem does this PR solve?

cherry pick #14127

What is changed and how it works?

avoid goroutine leak in explain analyze statements

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • avoid goroutine leak of projectExec in explain analyze statements.

@fzhedu fzhedu changed the title cherry pick goroutine leak PR to release-3.0 executor: avoid ProjectoinExec's goroutine leak #14127 Dec 25, 2019
@fzhedu fzhedu added the type/bugfix This PR fixes a bug. label Dec 25, 2019
SunRunAway
SunRunAway reviewed Dec 25, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/LGT1 Indicates that a PR has LGTM 1. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Dec 25, 2019
winoros
winoros approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fzhedu
Copy link
Contributor Author

fzhedu commented Dec 25, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2019

Sorry @fzhedu, you don't have permission to trigger auto merge event on this branch.

@bb7133
Copy link
Member

bb7133 commented Dec 26, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@fzhedu fzhedu changed the title executor: avoid ProjectoinExec's goroutine leak #14127 executor: avoid ProjectoinExec's goroutine leak (#14127) Dec 26, 2019
@sre-bot sre-bot merged commit 4eb6c8e into pingcap:release-3.0 Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzhedu @sre-bot @bb7133 @SunRunAway @winoros